Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

teacher tool carousel content #5509

Merged
merged 1 commit into from
Feb 26, 2024
Merged

teacher tool carousel content #5509

merged 1 commit into from
Feb 26, 2024

Conversation

eanders-ms
Copy link
Collaborator

Content for the teacher tool carousels. There's a lot here just to see what the home screen will look like filled out. We will want to whittle it down before we ship.

@eanders-ms eanders-ms self-assigned this Feb 23, 2024
@eanders-ms eanders-ms requested a review from a team February 23, 2024 01:52
"carousels": [
{
"title": "Rubrics for Tutorials",
"cardsUrl": "teachertool/carousels/rubrics-for-tutorials/cards.json"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocking question, I don't have a strong opinion either way, I just wanted to ask why we have each of the cards for the different carousels in separate folders instead of files. As in, keep the carousels directory, but in that directory, you just have games-rubric-cards.json, v2-tutorials-rubric-cards.json, and tutorial-rubric-cards.json instead of the folders. I think I just have a hard time imagining something else will go in the separate folders other than cards.json.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had the same question

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to model it after how the editor home page works, but it is inconsistent. I chose to go with the per-folder layout because it seemed more organized. Planning for a time when we have lots of rubric content, I wanted to make sure content editors would be able find the files they're looking for if/when we have lots of rubrics and carousels.

Copy link
Contributor

@srietkerk srietkerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, but not blocking. Looks great!

@eanders-ms eanders-ms merged commit 4f1d0cb into master Feb 26, 2024
7 checks passed
@eanders-ms eanders-ms deleted the eanders-ms/tt-carousels branch February 26, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants